ARROW-6999: [Python] Fix unnamed index when specifying schema in Table.from_pandas#5750
Closed
jorisvandenbossche wants to merge 4 commits into
Closed
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5750 +/- ##
===========================================
- Coverage 88.96% 66.92% -22.05%
===========================================
Files 992 534 -458
Lines 135218 75606 -59612
Branches 1501 0 -1501
===========================================
- Hits 120300 50596 -69704
- Misses 14553 25010 +10457
+ Partials 365 0 -365
Continue to review full report at Codecov.
|
fsaintjacques
left a comment
fsaintjacques
left a comment
Contributor
There was a problem hiding this comment.
Some small code structure proposition, non-blocking. I can't comment on the validity, I don't know what a RangeIndex is :)
Member
Author
|
@fsaintjacques Thanks for the review! Simplified a bit based on your comment, and also ended up combining both functions in one. |
pitrou
reviewed
Nov 4, 2019
pitrou
left a comment
pitrou
left a comment
Member
There was a problem hiding this comment.
LGTM. Just a very minor comment.
Member
There was a problem hiding this comment.
Gotta love this error message :-)
jorisvandenbossche
force-pushed
the
ARROW-6999-pandas-schema-index-columns
branch
from
29d9628 to
199de55
Compare
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/ARROW-6999